Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stars #3484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

OksanaVasinkevych
Copy link

Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Some minor fixes needed

src/style.css Outdated
Comment on lines 22 to 24
.star-active {
background-image: url(./images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant

Suggested change
.star-active {
background-image: url(./images/star-active.svg);
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

src/style.css Outdated
Comment on lines 13 to 15
background-image: url(images/star.svg);
background-repeat: no-repeat;
background-position: center;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can apply background shorthand

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants